Feat/config #3
Merged
Feat/config #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
FreakyWizard
commented
Nov 14, 2024
•
FreakyWizard
commented
- Created Config class and interface based on PHP CS Fixer variants
- Updated docs
- Installed array merger (don't reinvent the wheel)
- Wrote 18 tests
- Implemented new config with PHP CS Fixer
- Docs blocks for public functions
- Fixed github actions
- Fixed php version bugs
FreakyWizard
force-pushed
the
feat/config
branch
from
c120d13 to
d4de317
Compare
github-actions
bot
added
documentation
Composer package changes
|
FreakyWizard
force-pushed
the
feat/config
branch
from
cb98e84 to
a48b791
Compare
FreakyWizard
force-pushed
the
feat/config
branch
from
2392f4b to
ed513ce
Compare
SimonvanWijhe
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Nog een paar aanpassingen en daarna akkoord.
Zou je in de README bovenaan nog iets kunnen toevoegen in de trant van:
Dit zijn de php-cs-fixer rules die binnen het team WordPress gehanteerd worden voor sites en packages. Workflow voor auto commit kan je hier (linkje) vinden.
FreakyWizard
force-pushed
the
feat/config
branch
from
38e4381 to
1bd3018
Compare
SimonvanWijhe
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Ziet er goed! Ter info: Pest heeft een beforeEach hook waarmee code kunt uitvoeren die voor elke test moet plaats vinden: https://pestphp.com/docs/hooks
YvetteNikolov
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.